This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Fix extra tab icon appearing in iOS for TabbedPage (was #448) #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 1ba6ff67a745a0e802f67b7a4f36db4f8385466e Merge: e3f1937 a1d4b64 Author: Stephane Delcroix <stephane@delcroix.org> Date: Thu Jan 26 10:11:08 2017 +0100 Merge branch 'master' of git://github.com/ckimes89/Xamarin.Forms into ckimes89-master commit a1d4b64 Author: Chad Kimes <chad.kimes@iticentral.com> Date: Tue Oct 11 13:42:28 2016 -0400 [iOS] Fix extra tab icon appearing in iOS 10 commit 07cd17d Author: Chad Kimes <chad.kimes@iticentral.com> Date: Tue Oct 11 13:38:30 2016 -0400 [iOS] Add static check method for iOS 10
StephaneDelcroix
force-pushed
the
re-448
branch
from
fe8cbeb
to
4aa6149
Compare
4 tasks
mattleibow
pushed a commit
that referenced
this pull request
Jan 28, 2021
* Use SharedPreferences.Editor.Apply when editing to force disk write to be asynchronous (#637) * GH-182 Color/Point/Rect/Size Extension Converters (#651) * Add extension helpers for iOS and Android * Add UWP colors and adjsut android colors. * Add UWP Point/Rect/Size * Rename and optimize! * Add tests and color helpers! * Fix unit test and add WithAlpha * Cleanup iOS as it stores it from 0-1 * Tests are all green! * Add generate-docs cmd :) * Add docs config to all :) * Additional clenaup for docs * Added some docs * Updated the mdoc target and regenerated the docs * Allow for code reuse on macOS (#665) Even though macOS is not yet officially supported, it is nice to reuse this code. macOS is exactly the same, except for this single property not supported. * GH-196 Browser Customization (#646) * Implemented GH-196 * Apply suggestions from code review: Naming Renamed incorrectly spelled variables Co-Authored-By: Mrnikbobjeff <schillinik@yahoo.de> * Implemented GH-196 * Browser update work as requested. Using System.Drawing.Color now * Adopted more review changes. Type forwarded. * Review changes * Made equals operator null safe, removed constructor * Add documentation and simplify the API! * Update viewmodel * Back to 7.2 * GH-676 Require To Check GPS Location is Fake Or Not In GeoLocation (#677) * Added bool IsFromMockProvider in Location class * Checkin * csproj original * Revert "csproj original" This reverts commit 6302b95782006288862f0ce11100c81936baa7fb. * Revert "Checkin" This reverts commit 0881e4f12c36caecd08b3b9bb8757d8bd1025502. * Revert "Added bool IsFromMockProvider in Location class" This reverts commit e56d9406cf0a92d24b04607afe81aef23aca696c. * Revert the Xamarin.Essentials.csproj and Samples.Android.csproj to original; Adjust the property IsFromMockProvider in Location.shared and LocationExetensions. * Edited sample to show if the location is from moking provider. * Update docs * Fixes #694 (#699) * Update the mdoc to use the new minimum for VS2019 * GH-126: Finish Shake Detector API (#693) * Update CONTRIBUTING.md (#692) * GH-126 Detect Shake API (#666) * Added shaken support * name vhange * check-in * doc update * Implements the Shake API inside Accelerometer Class; Change sample to AccelorometerViewModel * Fix the sample project * Update the docs * Added Queue mechanism based off seismic with tests as well. Something is not right yet with calulating isaccelerating. * Finalize shake detection!!! * Re-generated the docs. * Fix the VM after merge * GH-704 Handle duplicate item in keychain (#705) * Update CONTRIBUTING.md (#692) * #704 if we get a duplicate item try to remove and then re-add if possible. * Initial commit Clipboard Change * Implemented Clipboard listeners on iOS, tested on android and uwp and fixed other issues related to Visual Studio for Mac and Essentials support. * Initial commit Clipboard Change * Implemented Clipboard listeners on iOS, tested on android and uwp and fixed other issues related to Visual Studio for Mac and Essentials support. * Naming fix * UI improvements * Docs update * docs update part 2 * docs tool breaking fix * reverted change to csproj
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[iOS] Fix extra tab icon appearing in iOS for TabbedPage
This branch pull #448 along, and add a test.
DO NOT SQUASH-MERGE TO PRESERVE AUTHOR ATTRIBUTION
This adds a workaround for an iOS 10 bug that displays extra icons in a UITabBarController when the UITabBarItem.Title property is changed. More info here: http://stackoverflow.com/questions/38776978/ios-10-uitabbar-more-items-visible-after-setting-title
Bugs Fixed
API Changes
Added:
PR Checklist